Skip to content

API: Set Object name when expunging VM #11352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sureshanaparti merged 1 commit into from
Jul 31, 2025
Merged

API: Set Object name when expunging VM #11352

sureshanaparti merged 1 commit into from
Jul 31, 2025

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Jul 30, 2025

Description

This PR fixes ##11345

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before Fix:

(localcloud) 🐱 > destroy virtualmachine id=d9465bcb-ccaa-4b67-b466-6058c83570a5 expunge=true 
{
  "null": {
    "affinitygroup": [],
    "deleteprotection": false,
    "nic": [],
    "securitygroup": [],
    "tags": []
  }
}

After fix:

(localcloud) 🐱 > destroy virtualmachine id=15eeb05a-3504-4dca-af26-bea8e6d60615  expunge=true 
{
  "virtualmachine": {
    "affinitygroup": [],
    "deleteprotection": false,
    "nic": [],
    "securitygroup": [],
    "tags": []
  }
}

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jul 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.16%. Comparing base (7e04143) to head (c80cb53).
⚠️ Report is 1 commits behind head on 4.20.

Files with missing lines Patch % Lines
...e/cloudstack/api/command/user/vm/DestroyVMCmd.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11352   +/-   ##
=========================================
  Coverage     16.16%   16.16%           
- Complexity    13278    13279    +1     
=========================================
  Files          5656     5656           
  Lines        497911   497912    +1     
  Branches      60383    60383           
=========================================
+ Hits          80464    80466    +2     
+ Misses       408492   408491    -1     
  Partials       8955     8955
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.01% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland added this to the 4.20.2 milestone Jul 30, 2025
DaanHoogland
DaanHoogland approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tnx @Pearl1594 , looks good will test

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 30, 2025

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jul 30, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 30, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blueorangutan
Copy link

blueorangutan commented Jul 30, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14475

sureshanaparti
sureshanaparti approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

shwstppr
shwstppr approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti sureshanaparti merged commit 2944bd1 into 4.20 Jul 31, 2025
48 of 49 checks passed
@sureshanaparti sureshanaparti mentioned this pull request Jul 31, 2025
Closed
@DaanHoogland DaanHoogland deleted the fix-destroy-vm-response branch July 31, 2025 06:59
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
@Pearl1594 @dhslove
API: Set Object name when expunging VM (apache#11352)
458a417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

5 participants

@Pearl1594 @DaanHoogland @blueorangutan @shwstppr @sureshanaparti